Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Binary Search Exercise #290

Closed
wants to merge 1 commit into from
Closed

Improve Binary Search Exercise #290

wants to merge 1 commit into from

Conversation

rabestro
Copy link
Member

  • Updated example implementation with the renamed variable and guard validation.
  • Updated test cases to reflect the new variable name and include the guard validation check.

@rabestro rabestro requested a review from a team January 21, 2025 15:39
@rabestro rabestro self-assigned this Jan 21, 2025
@rabestro rabestro added the x:action/improve Improve existing functionality/content label Jan 21, 2025
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@IsaacG
Copy link
Member

IsaacG commented Jan 21, 2025

Please get buy in from maintainers prior to creating PRs to modify exercises. See discussion on linked issue.

@IsaacG IsaacG closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/improve Improve existing functionality/content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants