-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: Add headers #559
base: master
Are you sure you want to change the base?
NEW: Add headers #559
Conversation
thanks for the ping @choldgraf re: |
Just wanted to say that sunpy are looking at adopting this theme and making a unified top navbar work is a must for us as well, so very excited to see this :) |
Many thanks @Cadair that is good to hear. If you have any suggestions to guide this functionality, the user API, etc please do share them! |
Thanks for the ping, @choldgraf! I think this would be an awesome feature that Project Pythia will use. So far, I can't see any design problems with its current form that would prevent us from just using it out of the box. Thanks for doing this! |
I also wanted to thank you for this! It makes rewriting the theme I am working on much easier! I do have one request (that I can understand if you decline): I would like to fix the navbar to the top of the viewport with the I think I can just extend the html using a template if not. I did notice that adding classes to the buttons (I didn't check dropdowns) added them as For context, I am trying to replicate: We fix the navbar and footer to the viewport (I have the footer simple enough by dropping in a new template). |
@nabobalis I think it should be possible to make the header One option would be to make this an "either / or" option. You either have a sticky header, or you have a sticky article header. But perhaps we could leave that to a future PR? |
(@nabobalis and I are both working on the sunpy theme at the moment) I think that I would be ok with the article header not being sticky (or just disabling it in the short term) for our use case, if we can have the top nav be sticky. Happy for you to leave it to another PR, whatever is easiest for you, we can probably hack around it as Nabil says for a while. Thanks for all your hard work :) |
https://foundations.projectpythia.org/landing-page.html I have not tried |
Sorry, I should have been clearer! In my current PR that I am working on, before I switched to test this branch. |
726d965
to
f1418c1
Compare
@choldgraf I just noticed this PR and would be interested to try it out once/if it gets to a good stable state. I achieved that by adding a Then, I took the same So, I would like to point out that I think it would be useful for projects like ours if the |
Close-reopened to retrigger the RTD build. |
Hello @choldgraf, I was wondering if this branch could be rebased on top of master? I tried to rebase this on my own fork but as I am too unfamiliar with the codebase, I do not think it is correct. |
This PR prototypes the addition of header content. This is a new UI element that lives above the sidebar and article header, and can be used to provide more high-level navigation and context for the page.
The elements of the header are populated via a component-style configuration (that we can re-use for the article header as well, once we have settled on a configuration structure). This lets you define the order, behavior, etc of header components in a relatively granular way.
The main use-case this is meant to solve for are cases where organizations have multiple documentation sites that require a consistent style across them (as opposed to the PyData Theme use case, which is a single documentation site with sub-sections). It is inspired by the implementations of a few users of this theme:
also cc @rabernat who said some of his projects would benefit from this
Todo
closes #182 closes jupyter-book/jupyter-book#1671