Skip to content

Commit

Permalink
tests: Add property tests and fix mypy
Browse files Browse the repository at this point in the history
  • Loading branch information
edeustua committed Jun 9, 2024
1 parent 12ecb43 commit da29e72
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
3 changes: 3 additions & 0 deletions src/pytest_checklist/pointer.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ def resolve_target_pointer(target: Callable[..., Any] | property) -> Pointer:
# NOTE: currently only supports functions and properties

if isinstance(target, property):
if target.fget is None:
raise ValueError("Property getter must be set")

module = target.fget.__module__
qualname = target.fget.__qualname__
else:
Expand Down
18 changes: 13 additions & 5 deletions tests/test_pointer.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import pytest

from pytest_checklist.pointer import (
resolve_pointer_mark_target,
resolve_target_pointer,
Pointer,
)
from pytest_checklist.pointer import (Pointer, resolve_pointer_mark_target,
resolve_target_pointer)

pointer = pytest.mark.pointer

Expand All @@ -13,6 +10,12 @@ def func_target():
pass


class PropertyTarget:
@property
def property_target(self):
pass


@pointer(target=resolve_target_pointer)
def test_resolve_target_pointer():

Expand All @@ -21,6 +24,11 @@ def test_resolve_target_pointer():
"tests.test_pointer.func_target",
)

assert resolve_target_pointer(PropertyTarget.property_target) == Pointer(
PropertyTarget.property_target,
"tests.test_pointer.PropertyTarget.property_target",
)


@pointer(target=resolve_pointer_mark_target)
def test_resolve_pointer_mark_target():
Expand Down

0 comments on commit da29e72

Please sign in to comment.