-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to perform octet streaming #1012
base: main
Are you sure you want to change the base?
feat: Add ability to perform octet streaming #1012
Conversation
…prove readability
ping @bernardd |
Hi @avinayak - sincere apologies for not getting to this sooner - it slipped through the cracks and I didn't get back to it. I will do my best to get to it this week. If I recall correctly, it failed some of the CI checks when they were run (but it's taken me so long to get back to it that the logs are now gone). If you're able to have a quick look at that that would be great. |
I'll fix the issues with this PR as soon as I can. Thanks for replying |
I am trying to Add support for S3 Select (https://docs.aws.amazon.com/AmazonS3/latest/userguide/selecting-content-from-objects.html) in ex_aws_s3.
However, the response of this request is an octet-stream and since this request does not support Range header, we cannot execute this request like how we do
ExAws.S3.download_file
.This PR is related to changes in ex-aws/ex_aws_s3#236