-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move RichGroup and RichCommand out of rich_click.py #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, much better - thanks 👍🏻 The console thing had been in the back of my mind for a bit as well.
I wonder if we can just create a single top-level global console object and then use that everywhere? (Similar to the highlighter
). I'm not sure that there's any need to create so many different versions of the same thing. Might be cleaner.
Yes to all of this 👍🏻 I'm a scientist first and coder second and have never gotten around to properly teaching myself to use typing. But I've been feeling increasingly guilty about it! If you fancy adding typing to this then that would be great actually, as it'll force me to use it for any new features I add 😅 Pre-commit stuff also good. Again I've never bothered setting this up myself (instead relying on VSCode plugins) but I should probably set myself up to use it. |
See also #12 but that lower priority stuff that can probably be handled in a separate PR |
I don't like global variables to be fair. |
Fixed black formatting 👍 . |
Sounds good 👍🏻 I'm not familiar with it but I'm happy to defer to you.. I agree about generally disliking globals for this kind of thing, I was mostly thinking about consistency as I saw the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog entries would be good, but as you're going to have a follow-on PR can do that later.
First of a couple refactorings that are coming up.
This refactoring:
I think to tune this file down more, we might consider moving all rich specific tools to a file called
rich_utils
and moving the click items intoclick_utils
.