Validate the function signature of main in binaryen #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 68.51% 68.63% +0.12%
==========================================
Files 8 8
Lines 1045 1049 +4
Branches 136 136
==========================================
+ Hits 716 720 +4
Misses 300 300
Partials 29 29 |
axic
force-pushed
the
validate-main-sig
branch
from
fd448f2 to
733cb6c
Compare
axic
force-pushed
the
validate-main-sig
branch
from
733cb6c to
15b9dc2
Compare
chfast
approved these changes
Oct 25, 2018
src/binaryen.cpp
Outdated
| ensureCondition( | ||
| main_function, | ||
| ContractValidationFailure, | ||
| "Contract is invalid. \"main\" export doesn't point to a function." |
| (main_function->getNumParams() == 0) && | ||
| (main_function->result == wasm::Type::none), | ||
| ContractValidationFailure, | ||
| "Contract is invalid. \"main\" has an invalid signature." |
There was a problem hiding this comment.
(The) "main" function has invalid signature
axic
force-pushed
the
validate-main-sig
branch
from
15b9dc2 to
ab24465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #441. Fixes #442.