Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check favorite session feature #4

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Add check favorite session feature #4

wants to merge 25 commits into from
+231 −13

Conversation

ewa1989
Copy link
Owner

@ewa1989 ewa1989 commented Mar 17, 2024 •
edited
Loading

Add check favorite session feature as below.

Only in ShceduleView, show star icons on the right inside of session row, toggle when the icons are tapped, and persist favorited states.

Ref: tryswift#40

Note

  • persist [String: [Session]] in Document as Json files, in save methods of FileClient
  • when app launch, try to load [String: [Session]] from Document

@ewa1989
add star icon in the right of session row
875b195
@ewa1989
change icon according to the session is favorited
33888d9
@ewa1989
create new action, view favoriteIconTapped
08a2b0d
@ewa1989
change to toggle favorite condition of tapped session
c32c5bf
@ewa1989
change to save and load conferences in UserDefaullts
cf49338
@ewa1989
Merge commit '1b5005da964abcaf5a5865b68347ab32d6e72aa2' into add-chec…
5a32df4 
…k-favorite-session-feature

# Conflicts:
#	MyLibrary/Sources/ScheduleFeature/Schedule.swift
@ewa1989
change save data type as [String: [Session]] for performance
846098f
@ewa1989
extract favorites load/save methods to FileClient, separating with fe…
23983b5 
…tching methods which might change API Client in future
@ewa1989
Merge branch 'main' into add-check-favorite-session-feature
a7a611b 
# Conflicts:
#	MyLibrary/Sources/ScheduleFeature/Schedule.swift
@ewa1989
change file save/load area to Document that is more appropriate becau…
0e8b403 
…se favorite data aren't customizing app's behavior
@ewa1989
fix failed test due to adding load Favorites when onAppear
daa7fa7
@ewa1989
separate saving favorites and updating state for testability
1a5419a
@ewa1989
add tests for adding/removing favorites
35b4d14
@ewa1989
extract json encoder and decorder as JSONHandler
f2622b8
@ewa1989
Revert "extract json encoder and decorder as JSONHandler"
b648df2 
This reverts commit f2622b8.
@ewa1989
separate FileClient
a929586
@ewa1989
move mocks that are intended for specific behavior near related tests
4e279e4
@ewa1989
Merge branch 'main' into add-check-favorite-session-feature
1db51b5 
# Conflicts:
#	MyLibrary/Package.swift
#	MyLibrary/Sources/ScheduleFeature/Schedule.swift
@ewa1989
remove unused mock
d3a49ab
@ewa1989
fix to separate load favorites from fetch data, and to assert separat…
04cefc0 
…ely in tests.
@ewa1989
to keep models having no logics, move logics in Favorites to Reducer …
d3b9901 
…and View, and remove Favorites and use typealias instead because Favorites has one property only.
@ewa1989
rename saveDataToFile and loadDataFromFile to explain exactly how the…
cfb2fa3 
…y do.
@ewa1989
change variable name of Conference, day to conference, as other place…
77b7a09 
… does
@ewa1989
fix to combine load response into fetch response for simplicity.
0e3b9f8
@ewa1989
move a part of logic to Reducer for collecting logics relative with s…
6cca9bd 
…tate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ewa1989