Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi maintainers,
This is a really good template and I'm using it in my project, but I find the test file here does not run tests in parallel correctly. Mock's EXPECTs are very likely to have a conflict when there are many (like 10) tests running concurrently. This issue could be easily reproduced by copying test cases 10 times and then running tests 10 times. You will be very likely to see there are 1 or 2 test cases that failed. Therefore, I add a lock here to avoid conflicts.
Thanks