Refactor code for java-threads-example

evrentan · Aug 14, 2022 · a74b9db · a74b9db
1 parent 51dae10
commit a74b9db
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/java-threads-example/src/MyThreadClassExtendsThread.java b/java-threads-example/src/MyThreadClassExtendsThread.java
@@ -7,7 +7,7 @@ public MyThreadClassExtendsThread(String threadName) {
   @Override
   public void run() {
     int amount = 0;
-    ThreadManagementUtility.printThreadEnd(this.getClass().getCanonicalName(), Thread.currentThread().getName(), Thread.currentThread().getState());
+    ThreadManagementUtility.printThreadStart(this.getClass().getCanonicalName(), Thread.currentThread().getName(), Thread.currentThread().getState());
     ThreadManagementUtility.executeThread(amount, Thread.currentThread().getName(), Thread.currentThread().getState());
     ThreadManagementUtility.printThreadEnd(this.getClass().getCanonicalName(), Thread.currentThread().getName(), Thread.currentThread().getState());
   }

diff --git a/java-threads-example/src/MyThreadClassImplementingRunnable.java b/java-threads-example/src/MyThreadClassImplementingRunnable.java
@@ -3,7 +3,7 @@ public class MyThreadClassImplementingRunnable implements Runnable {
   @Override
   public void run() {
     int amount = 0;
-    ThreadManagementUtility.printThreadEnd(this.getClass().getCanonicalName(), Thread.currentThread().getName(), Thread.currentThread().getState());
+    ThreadManagementUtility.printThreadStart(this.getClass().getCanonicalName(), Thread.currentThread().getName(), Thread.currentThread().getState());
     ThreadManagementUtility.executeThread(amount, Thread.currentThread().getName(), Thread.currentThread().getState());
     ThreadManagementUtility.printThreadEnd(this.getClass().getCanonicalName(), Thread.currentThread().getName(), Thread.currentThread().getState());
   }

diff --git a/java-threads-example/src/ThreadManagementUtility.java b/java-threads-example/src/ThreadManagementUtility.java
@@ -1,8 +1,17 @@
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
 public class ThreadManagementUtility {
 
+  private ThreadManagementUtility() {
+    throw new IllegalStateException("Utility Class");
+  }
+
   private static final int THREAD_SLEEP_IN_MILLIS = 1000;
 
-  protected void printThreadStart(String clazzName, String threadName, Thread.State threadState) {
+  private static final Logger logger = Logger.getLogger(ThreadManagementUtility.class.getCanonicalName());
+
+  protected static void printThreadStart(String clazzName, String threadName, Thread.State threadState) {
     System.out.println(String.format("%s is starting for %s and thread state is %s !!!", clazzName, threadName, threadState));
   }
 
@@ -18,7 +27,8 @@ protected static void executeThread(int amount, String threadName, Thread.State
         System.out.println(String.format("**** Value of amount is %d from %s thread and thread status is %s ****", amount, threadName, threadState));
       }
     } catch (InterruptedException e) {
-      e.printStackTrace();
+      logger.log(Level.SEVERE, e.getMessage());
+      Thread.currentThread().interrupt();
     }
   }
 }