Merge pull request #17 from vivekpanchal/Fix_networkError

Fixed the Network Issue due to the CLEARTEXT error
evrencoskun · Jan 10, 2020 · 00cbac4 · 00cbac4
2 parents f19476a + 035a78a
commit 00cbac4
Show file tree

Hide file tree

Showing 4 changed files with 125 additions and 1 deletion.
diff --git a/.idea/codeStyles/Project.xml b/.idea/codeStyles/Project.xml
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -10,6 +10,8 @@
         android:label="@string/app_name"
         android:roundIcon="@mipmap/ic_launcher_round"
         android:supportsRtl="true"
+        android:usesCleartextTraffic="true"
+        android:networkSecurityConfig="@xml/network_config"
         android:theme="@style/AppTheme">
         <activity
             android:name=".ui.MainActivity">

diff --git a/app/src/main/java/com/evrencoskun/tableviewsample2/data/network/NetworkUtils.java b/app/src/main/java/com/evrencoskun/tableviewsample2/data/network/NetworkUtils.java
@@ -26,7 +26,7 @@
 public class NetworkUtils {
 
     private static final String LOG_TAG = NetworkUtils.class.getSimpleName();
-    private static final String BASE_URL = "http://vuetable.ratiw.net/api/";
+    private static final String BASE_URL = "https://vuetable.ratiw.net/api/";
 
     private static Retrofit getRetrofit() {
         return new Retrofit.Builder().baseUrl(BASE_URL).addConverterFactory(GsonConverterFactory

diff --git a/app/src/main/res/xml/network_config.xml b/app/src/main/res/xml/network_config.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<network-security-config>
+    <domain-config cleartextTrafficPermitted="true">
+        <domain includeSubdomains="true">localhost</domain>
+    </domain-config>
+</network-security-config>