-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Lib tableviewutil; reduce number of required app specific Classes; added generic parameter POJO; Updated Demo-App #406
Open
k3b
wants to merge
35
commits into
evrencoskun:master
Choose a base branch
from
k3b:OOExample
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lib" This reverts commit ca97dea.
…>> becomes List<iRow<Pojo>>)
…>> becomes List<iRow<Pojo>>)
… to com.evrencoskun.tableviewutil.holder
…vrencoskun.tableviewsample to com.evrencoskun.tableviewutil
…nDefinition<POJO>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation at https://github.com/evrencoskun/TableView
requires a lot of copy&paste from example code to use the TableView in a clientapp.
Product vision: reduce the amount of (copied) code to integrate TableView into a clientapp.
List<MySamplePojo> from TestData.createSampleData()
)List<ColumnDefinition<MySamplePojo>>
fromTestData.createColumnDefinitions()
)Additional Requirements
Some differences between old and new style app that uses tableview
old style:
build.gradle dependencies:
Mainfragment.java
Define app specific classes and resources
MainFragment.java
MainActivity.java
MainViewModel.java
MyTableViewModel.java
ColumnHeaderViewHolder.java
MyTableAdapter.java
CellModel.java
RowHeaderViewHolder.java
MyTableViewListener.java
ColumnHeaderModel.java
GenderCellViewHolder.java
MoneyCellViewHolder.java
RowHeaderModel.java
CellViewHolder.java
ic_down.xml
ic_up.xml
activity_main.xml
fragment_main.xml
tableview_cell_layout.xml
tableview_column_header_layout.xml
tableview_corner_layout.xml
tableview_gender_cell_layout.xml
tableview_money_cell_layout.xml
tableview_row_header_layout.xml
new style:
build.gradle dependencies:
Mainfragment.java
Define app specific classes and resources
MySamplePojo.java
MyTableViewListener.java
TestData.java
MainActivity.java
MainFragment.java
activity_main.xml
fragment_main.xml