Add default case #387
Open
Add default case #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGaetan89
reviewed
Aug 18, 2021
| @@ -115,6 +115,8 @@ public boolean onMenuItemClick(MenuItem menuItem) { | |||
| case SCROLL_ROW: | |||
| mTableView.scrollToRowPosition(5); | |||
| break; | |||
| default: | |||
| break; | |||
There was a problem hiding this comment.
Shouldn't you return false here? Same in the other file.
There was a problem hiding this comment.
Indeed, false should be returned here. I'll fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onMenuItemClickfunction is missing the default case, and a warning will be reported in Android Studio.