Merged
Conversation
marmoure
force-pushed
the
maven/plugin
branch
from
f6c59c5 to
787fcd2
Compare
marmoure
force-pushed
the
maven/plugin
branch
from
787fcd2 to
e1283a6
Compare
adamretter
requested changes
Jan 29, 2026
Member
adamretter
left a comment
adamretter
left a comment
There was a problem hiding this comment.
You seem to be missing the release profile configuration for the release plugin - please see the example I provided (https://github.com/evolvedbinary/expath-package-repository-plugin/blob/main/pom.xml)
pom.xml
Outdated
| </dependency> | ||
|
|
||
| <!-- https://mvnrepository.com/artifact/com.fasterxml.uuid/java-uuid-generator --> | ||
| <!-- https://mvnrepository.com/artifact/com.fasterxml.uuid/java-uuid-generator --> |
pom.xml
Outdated
| <Git-Commit>${build-commit}</Git-Commit> | ||
| <Git-Commit-Abbrev>${build-commit-abbrev}</Git-Commit-Abbrev> | ||
| <Build-Version>${build-version}</Build-Version> | ||
| <Build-Timestamp>${build-tstamp}</Build-Timestamp> |
Member
There was a problem hiding this comment.
Use of <Build-Timestamp> This is wrong! See the maven-jar-plugin config above
pom.xml
Outdated
| <Git-Commit>${build-commit}</Git-Commit> | ||
| <Git-Commit-Abbrev>${build-commit-abbrev}</Git-Commit-Abbrev> | ||
| <Build-Version>${build-version}</Build-Version> | ||
| <Build-Timestamp>${build-tstamp}</Build-Timestamp> |
Member
There was a problem hiding this comment.
Use of <Build-Timestamp> This is wrong! See the maven-jar-plugin config above
marmoure
force-pushed
the
maven/plugin
branch
from
2e2d2fe to
8737415
Compare
adamretter
reviewed
Jan 30, 2026
pom.xml
Outdated
| <configuration> | ||
| <autoVersionSubmodules>true</autoVersionSubmodules> | ||
| <tagNameFormat>bbl-validator-@{project.version}</tagNameFormat> | ||
| <releaseProfiles>bbl-validator</releaseProfiles> |
Member
There was a problem hiding this comment.
Rename to bbl-validator-release please
adamretter
reviewed
Jan 30, 2026
adamretter
reviewed
Jan 30, 2026
pom.xml
Outdated
| <artifactId>maven-release-plugin</artifactId> | ||
| <version>3.2.0</version> | ||
| <configuration> | ||
| <autoVersionSubmodules>true</autoVersionSubmodules> |
Member
There was a problem hiding this comment.
This line can be removed - as we don't have any Maven sub-modules
marmoure
commented
Jan 30, 2026
marmoure
commented
Jan 30, 2026
marmoure
commented
Jan 30, 2026
adamretter
approved these changes
Jan 30, 2026
marmoure
added a commit
that referenced
this pull request
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some maven plugin to to prepare the build and release it