feat: make event communication more reliable #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilbaczek
changed the title
kamilbaczek
commented
Nov 11, 2023
Chapter-3-microservice-extraction/Fitnet/Src/Fitnet/appsettings.Development.json
Show resolved
Hide resolved
kamilbaczek
commented
Nov 11, 2023
...cs/ArchitectureDecisionLog/0023-implementation-of-Inbox-Outbox-Pattern-with-MassTransit.adoc
Show resolved
Hide resolved
kamilbaczek
commented
Nov 13, 2023
...microservice-extraction/Fitnet.Contracts/Src/Fitnet.Contracts/Properties/launchSettings.json
Show resolved
Hide resolved
kamilbaczek
commented
Nov 15, 2023
...icroservice-extraction/Fitnet/Src/Passes/Fitnet.Passes.Api/Common/EventBus/EventBusModule.cs
Outdated
Show resolved
Hide resolved
kamilbaczek
commented
Nov 15, 2023
...icroservice-extraction/Fitnet/Src/Passes/Fitnet.Passes.Api/Common/EventBus/EventBusModule.cs
Outdated
Show resolved
Hide resolved
meaboutsoftware
requested changes
Nov 18, 2023
...ce-extraction/Fitnet.Contracts/Src/Fitnet.Contracts.IntegrationEvents/ContractSignedEvent.cs
Outdated
Show resolved
Hide resolved
Chapter-3-microservice-extraction/Fitnet/Src/Fitnet/appsettings.json
Outdated
Show resolved
Hide resolved
...ion/Fitnet/Src/Passes/Fitnet.Passes.IntegrationEvents/Fitnet.Passes.IntegrationEvents.csproj
Outdated
Show resolved
Hide resolved
Chapter-3-microservice-extraction/Fitnet/Src/Reports/Fitnet.Reports/Fitnet.Reports.csproj
Show resolved
Hide resolved
…cts Infrastructure insted use common infrastructure
The applicationUrl parameter in Fitnet.Contracts launchSettings.json file has been updated. The localhost port has been changed from 5013 to 5010 to reflect the new server configuration.
The baseUrl for localhost has been changed in the http-client.env.json file. It is now set to use port 5010 instead of the previous port 5013.
The connection string for the "Contracts" database has been removed from the appsettings.Development.json file. This reflects that the "Contracts" database is not needed anymore, and it keeps the configuration clean and relevant.
The removed classes, PassesConsumers and ContractSignedRegistration, were part of the event and consumer registration process. Their functions have been improved and integrated into other parts of the code to optimize our programming architecture.
Deprecated the EventBus as we have chosen to directly use MassTransit's `IPublishEndpoint` instead for event publishing. All dependency on the previously implemented EventBus, along with the EventBusOptions class, has been removed across the codebase. The handlers and consumers have been refactored accordingly.
Adjusted the MarkPassAsExpiredEndpoint to use the Common.EventBus dependency. This change involves binding IPassesBus and IPublishEndpoint to ensure correct event publication upon pass expiration. The publishEndpoint is now wrapped in a Bind object, improving its use in event publication.
Several unnecessary spaces and code lines have been removed in various files to improve the code's readability and maintainability. Also, the BloggingContextFactory class in PassesPersistence.cs, which was not being used, has been eliminated.
The MassTransit package, version 8.1.1, has been added to the IntegrationTestsToolbox project to facilitate the messaging framework for our tests. This addition will provide the necessary support for testing distributed systems.
Changes have been made in various configurations both on the application and development level. On the appsettings files, "Offers", "Passes", and "Reports" features and connection strings have been removed. Furthermore, the LogLevel has been changed from "Information" to "Debug". In the solution file, the "Fitnet.Common.Infrastructure" project has been removed.
The EventBusModule configuration in the Fitnet.Passes.Api project has been updated to include System.Reflection and to set the KebabCaseEndpointNameFormatter() function. Additionally, consumers from the currently executing assembly have been added to the configurator.
Changes in this commit include updating the access modifiers on ContractSignedEventConsumer and ContractSignedEventConsumerDefinition from 'internal' to 'public' for wider access. The configuration for the event bus and logging level was updated along with removal of redundant projects. The EndpointNameFormatter was also switched from using KebabCase to SnakeCase to better align with conventions.
The IPassesBus interface was removed as it wasn't necessary. The related code in the MarkPassAsExpiredEndpoint.cs was refactored to use the IPublishEndpoint directly. This makes the code cleaner and more efficient.
The launchSettings.json files for Fitnet and Fitnet.Contracts were altered to stop the automatic launch of the browser when the project starts. This change provides users with more control over when and how they want to interact with the projects.
kamilbaczek
force-pushed
the
feature/make_queues_more_resillient
branch
from
f0fc80c to
0d40c98
Compare
…com/evolutionary-architecture/evolutionary-architecture-by-example into feature/make_queues_more_resillient
kamilbaczek
commented
Nov 23, 2023
...ion/Fitnet/Src/Passes/Tests/Fitnet.Passes.IntegrationTests/RegisterPass/RegisterPassTests.cs
Show resolved
Hide resolved
Simplified the initialization of HttpContext in the ExceptionMiddlewareTests class. This refactor removes unnecessary lines and makes the code cleaner, moving the initialization of the _context field directly in its declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes:
Not includes: