fix: Redis password empty string treated as None

[sistemabritto]

Problema

Quando REDIS_PASSWORD esta vazio (comum em Docker Compose community sem senha), os.getenv retorna '' em vez de None. O redis-py envia AUTH com string vazia, que o Redis rejeita:

AUTH called without any password configured for the default user. Are you sure your configuration is correct?

Fix

1. get_redis_config() em redis.py: normaliza string vazia/whitespace para None
2. MCPToolCache.init em mcp_cache.py: protecao defensiva similar

Co-Authored-By: sistemabritto admin@workflowapi.com.br

Summary by Sourcery

Bug Fixes:

• Prevent Redis authentication errors when REDIS_PASSWORD or configured Redis passwords are set to an empty string instead of being omitted.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR ensures that an empty Redis password (common in Docker setups without authentication) is normalized to None both when reading configuration and when constructing the Redis client, preventing redis-py from sending an invalid AUTH command.

Sequence diagram for Redis password normalization and client initialization

sequenceDiagram
    actor Env
    participant get_redis_config
    participant MCPToolCache
    participant redis_client as redis_Redis
    participant RedisServer

    Env->>get_redis_config: os.getenv REDIS_PASSWORD
    get_redis_config->>get_redis_config: normalize empty string to None
    get_redis_config-->>MCPToolCache: redis_config(password=None)

    MCPToolCache->>MCPToolCache: normalize empty password to None
    MCPToolCache->>redis_client: Redis(host, port, db, password=None, ssl)

    alt [password is None]
        redis_client->>RedisServer: CONNECT without AUTH
    else [password not None]
        redis_client->>RedisServer: AUTH password
    end

Loading

File-Level Changes

Change	Details	Files
Normalize empty/whitespace REDIS_PASSWORD values to None at configuration load time.	Read REDIS_PASSWORD into a local variable before building the config dict. Add a check that converts empty or whitespace-only REDIS_PASSWORD values from the environment to None. Use the normalized redis_password value in the returned Redis configuration instead of reading directly from the environment.	src/config/redis.py
Add defensive normalization of empty Redis passwords when instantiating the cache Redis client.	Retrieve the password from the Redis configuration and normalize empty or whitespace-only values to None. Pass the normalized password into redis.Redis(...) instead of the raw configuration value.	src/services/adk/mcp_cache.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The empty-string password normalization is implemented both in get_redis_config and MCPToolCache.__init__; consider centralizing this logic in the config layer to avoid duplication and potential divergence.
• If redis_config['password'] can only be None or a string, the extra str(...) wrapping in MCPToolCache.__init__ is unnecessary and could be simplified to keep the handling clearer.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The empty-string password normalization is implemented both in `get_redis_config` and `MCPToolCache.__init__`; consider centralizing this logic in the config layer to avoid duplication and potential divergence.
- If `redis_config['password']` can only be `None` or a string, the extra `str(...)` wrapping in `MCPToolCache.__init__` is unnecessary and could be simplified to keep the handling clearer.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}