fixes the calculation of alignment for dynamic width shapes #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to fix the behaviour of alignment for plain text type shapes (label, text box, box, etc). Previously the width for these was hardcoded at 2000 which means center and right alignment would cause the content to 'disappear' off the visible canvas.
This change allows types to define dynamic width so that alignment is calculated with respect to the longest line of content or container width, whichever is first.
See a video here for test cases and explanation: https://www.loom.com/share/db04a47c71124cf5a6d42e402f68dabc