Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes the calculation of alignment for dynamic width shapes #692

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

EliotJones
Copy link

This change aims to fix the behaviour of alignment for plain text type shapes (label, text box, box, etc). Previously the width for these was hardcoded at 2000 which means center and right alignment would cause the content to 'disappear' off the visible canvas.

This change allows types to define dynamic width so that alignment is calculated with respect to the longest line of content or container width, whichever is first.

See a video here for test cases and explanation: https://www.loom.com/share/db04a47c71124cf5a6d42e402f68dabc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant