Fixes issue with openInNewTab for DataTable rows #3106
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d not actually open the link in a new tab
olegam
requested a deployment
to
Approval required to run action on external PR
GitHub Actions
Waiting
olegam
requested a deployment
to
Approval required to run action on external PR
GitHub Actions
Waiting
archiewood
temporarily deployed
to
Approval required to run action on external PR
GitHub Actions
Inactive
archiewood
deployed
to
Approval required to run action on external PR
GitHub Actions
Active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where clicking a table row link with openInNewTab=true did not actually open the link in a new tab
Description
There was an issue where setting openInNewTab for a DataTable row would still open the link in the same tab. This can be tested with the example project on the page
/tables/new-table/by clicking a row in the first table. It opens the link (a Google search) in the same tab even though openInNewTab=true is set. This happens because there is an on:click handler on the TableRow that doesn't take the target=_blank property into account.