-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RTL to settings #159
base: master
Are you sure you want to change the base?
add RTL to settings #159
Conversation
Thanks for the update.
What was the problem? |
Morning @evgenyneu when I switch from English to Arabic, the cosmo layer doesn't flip until I close the app and reopen it. This is due to the fact your library depends on RightToLeft helper that uses |
Thanks for clarification. By "switch from English to Arabic" do you mean switching the language of the OS in the iPhone settings? |
@evgenyneu not the phone language the app language I'm doing it on the fly so I don't need the app to shutdown |
@abdallahnh, interesting, what kind of app is that? Usually apps show the same as the OS. But in your case, you want your app language to be different from that of the OS? Why? |
@evgenyneu TotersApp food delivery, we give the option to our clients to switch between (Arabic/English/Kurdish) |
Updating from source repo
@evgenyneu why we didn't merge this change? I would like to link back to the cosmos git I'm now using my own branch |
Adding option in CosmosSettings to set RTL this is needed if you are switching languages and you don't need to close the app, so now from my app, I'm using a function isRTL() and set it to settings.isRTL and this fixed the weird behavior when I switch languages