Add page limit setting. #706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weyland
commented
Mar 28, 2025
| <label class="col-md-6 col-form-label" for="page_limit">{{ trans('web::seat.page_limit') }}</label> | ||
| <div class="col-md-6"> | ||
| <select id="page_limit" name="page_limit" class="form-control w-100"> | ||
| @foreach([10, 25, 50, 100, -1] as $limit) |
There was a problem hiding this comment.
I could possibly pull this from the predefined profile settings? If so, could you let me know how? Saves me redefining it here is all.
Weyland
commented
Mar 28, 2025
Comment on lines
+137
to
+144
|
|
||
| <script> | ||
| // Inject the page limit value with fallback to 10 if not set. | ||
| // | ||
| // This is required as `seat.js` uses this variable, with their own fallback, just in case. | ||
| var pageLength = {{ setting('page_limit') ?? 10 }}; | ||
| </script> | ||
|
|
There was a problem hiding this comment.
Ideally I could have used this variable directly in seat.js but since it's not a blade template, that wasn't possible. I'd love to have another look and see if there is a better way to solve this. Could use some guidance on doing so but I think I can manage that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a page limit setting that is respected by all datatables.
Additionally fixed a Bootstrap grid layout thing.
Oh, and you can show
Allresults in a table now. Something that would cause some load on the server, up to you if you want to keep it or not. I can remove it again.