Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 extension image upload #694

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

casank25
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

#692
Issue Number: 692

What is the new behavior?

S3 Extension properly uploads images, sets content type and ACL permissions so that image can be displayed in the admin panel and front store.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@casank25 casank25 changed the title Fix lint error Fix S3 extension image upload Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant