Removes KRAKEN_CREDENTIALS Environment Variable From Being Exposed I…

…n Jenkins Logs (#510) * Removes KRAKEN_CREDENTIALS Environment Variable From Being Exposed In Logs When Publishing Master * Removes Patch File
evernym · Sep 14, 2018 · 6b4044c · 6b4044c
1 parent 8a02353
commit 6b4044c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/vcx/ci/Jenkinsfile b/vcx/ci/Jenkinsfile
@@ -112,15 +112,15 @@ def mainUbuntu() {
                     withCredentials([usernameColonPassword(credentialsId: 'jenkins-kraken-svc', variable: 'KRAKEN_CREDENTIALS')]) {
                         libvcx.inside("--network=host") {
                             // ******** Publish Libvcx Debian to repo ********
-                            sh "vcx/ci/scripts/publish.sh \"${KRAKEN_CREDENTIALS}\" \"libvcx*.deb\" https://kraken.corp.evernym.com/repo/portal_dev/upload"
-                            sh "vcx/ci/scripts/publish.sh \"${KRAKEN_CREDENTIALS}\" \"libvcx*.deb\" https://kraken.corp.evernym.com/repo/agency_dev/upload"
+                            sh "vcx/ci/scripts/publish.sh \"libvcx*.deb\" https://kraken.corp.evernym.com/repo/portal_dev/upload"
+                            sh "vcx/ci/scripts/publish.sh \"libvcx*.deb\" https://kraken.corp.evernym.com/repo/agency_dev/upload"
 
                             // ******** Publish Npm Package to filely repo ********
-                            sh "vcx/ci/scripts/publish.sh \"${KRAKEN_CREDENTIALS}\" \"*.tgz\" https://kraken.corp.evernym.com/repo/npm/upload"
+                            sh "vcx/ci/scripts/publish.sh \"*.tgz\" https://kraken.corp.evernym.com/repo/npm/upload"
 
                             // ******** Publish vcx Debian To Repo (NPM PACKAGES)
-                            sh "vcx/ci/scripts/publish.sh \"${KRAKEN_CREDENTIALS}\" \"vcx_*.deb\" https://kraken.corp.evernym.com/repo/agency_dev/upload"
-                            sh "vcx/ci/scripts/publish.sh \"${KRAKEN_CREDENTIALS}\" \"vcx_*.deb\" https://kraken.corp.evernym.com/repo/portal_dev/upload"
+                            sh "vcx/ci/scripts/publish.sh \"vcx_*.deb\" https://kraken.corp.evernym.com/repo/agency_dev/upload"
+                            sh "vcx/ci/scripts/publish.sh \"vcx_*.deb\" https://kraken.corp.evernym.com/repo/portal_dev/upload"
 
 
                             // ******** Archive with Jenkins ********
@@ -130,7 +130,7 @@ def mainUbuntu() {
                             java.inside() {
                                 sh 'cp $settingsFile .'
                                 sh "chmod +x vcx/wrappers/java/ci/publishJar.sh"
-                                sh 'vcx/wrappers/java/ci/publishJar.sh'
+                                sh 'vcx/wrappers/java/ci/publishJar.sh'find
                             }
                         }
 

diff --git a/vcx/ci/scripts/publish.sh b/vcx/ci/scripts/publish.sh
@@ -5,9 +5,9 @@ if [ $# -ne 3 ]; then
     exit 1
 fi
 
-CREDENTIALS=$1
-FILENAME=$2
-URL=$3
+CREDENTIALS=$KRAKEN_CREDENTIALS
+FILENAME=$1
+URL=$2
 LOOKUP_DIR="output"
 
 echo "Filename: ${FILENAME}"