Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements: Aggregates #1069

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

alexeyfv
Copy link
Contributor

@alexeyfv alexeyfv commented Jan 5, 2025

Hello,

I made the following improvements to the Aggregate page:

  1. Added a link to the Identity page. Seems like it was missing.
  2. Briefly explained why it's important to use the SingleValueObjectConverter class with the Identity class.
  3. Changed the code snippet in the "Using Events" section to make it more clear.
  4. Added examples of how to modify aggregates using the IAggregateStore and the CQRS approach.

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Documentation/basics/aggregates.md Show resolved Hide resolved
Documentation/basics/aggregates.md Show resolved Hide resolved
@rasmus
Copy link
Member

rasmus commented Jan 6, 2025

Some very odd comments from copilot. Testing it out to see if it actually has any value.

@rasmus
Copy link
Member

rasmus commented Jan 6, 2025

Thanks for the updates. It really means a lot!

@rasmus rasmus merged commit 221f4ac into eventflow:develop-v1 Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants