refactor/workspaces #946
Closed
refactor/workspaces #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It avoid copying the core to the user's directory when the `.eventcatalog-core` already exists and has the same version as the `@eventcatalog/core`.
It adds a simple logger that wraps Console. Based on the logLevel enabled this logger decides between print or not the message.
It removes copyCore from preview command as it doesn't adds any value.
It adds the options --project-dir and --ec-core-dir to define the PROJECT_DIR (default to cwd) and CORE_DIR (default to cwd + `.eventcatalog-core`) respectively.
The test ci script is used by .github actions, keeping it under .github makes more sense. The images is used by the README.md.
|
|
Closing in favor of small PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, sorry for the PR size...
Motivation
Closes #575.
What it does?
watcher,hydrateandlog-buildinto module, so we can call them "inside" the cli command instead of executing with node.pinoas a simple logger.packages/core/astro/. This adds a burden to us for install deps on user's.eventcatalog-coredir. It is handled here.packages/core/. Theastro/must be inside ofcore/to turns the pack process simple. The files packaged are described into thefilesfield on package.json (check here)Changes into
core/cliscripts/*toscr/*bin/eventcatalog.config.tstoconfig.d.tsbin/eventcatalog.tstosrc/eventcatalog.tseventcatalog.jsinto the bin filescripts/__tests__/**totest/**to simplify the tests location onvitest.config.tsChanges into
github actionstest-binworkflow with docker and adds it as job into theverify-buildworkflow. This job will be executed in windows/ubuntu and with pnpm/npm.