Skip to content

Conversation

@schreibubi
Copy link

Initial draft of building Armbian images which support openWB

Copy link

@ngehrsitz ngehrsitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for getting out-of the-box OpenWB support

Comment on lines 260 to 261
mkdir -p /var/lib/systemd/linger/ || true
touch /var/lib/systemd/linger/admin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should do the same as

Suggested change
mkdir -p /var/lib/systemd/linger/ || true
touch /var/lib/systemd/linger/admin
loginctl enable-linger admin

Comment on lines +264 to +269
# ============================================================================
# Fix homedirectory permissions
# ============================================================================
cp -r /etc/skel/. /home/admin/ 2>/dev/null
chown -R admin:admin /home/admin
chmod 755 /home/admin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wasn´t this necessary before?

cat >/etc/evcc.yaml <<YAML
network:
schema: https
schema: http

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this?

echo "[customize-image] OpenWB with display customizations"
apt-get install -y --no-install-recommends labwc wayfire seatd xdg-user-dirs firefox-esr swayidle wlopm

mkdir -p /home/admin/.config/labwc || true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can this fail?

# Pre-generate minimal config if missing
if [[ ! -f /etc/evcc.yaml ]]; then
cat >/etc/evcc.yaml <<YAML
cat >/etc/evcc.yaml <<YAML

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also pre-generate the config from evcc-io/evcc#21984
The only thing missing to avoid manual configuration would be smart meter detection which is why I suggested auto-detecting that in code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants