Use official vite+ image for Devcontainer - #33564
Merged
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
🟢 Approval recommended
The configuration resolves the missing Vite+ CLI while preserving the required Go development environment.
Pull request overview
Updates the development container to use the official Vite+ image while retaining Go support.
Changes:
- Pins the Vite+ image by digest.
- Replaces Node and bundled Go setup with the Go Feature.
- Configures Go 1.27 and requests skipping optional Go tools.
🤖 Generated with GitHub Copilot
File summaries
| File | Description |
|---|---|
.devcontainer/devcontainer.json |
Configures the Vite+ base image and Go toolchain. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #33295 and replaces PR #33302
Adopt changes in #33373 for Devcontainers too.
I successfully tested the changes in a local Devcontainer environment running on a Synology Diskstation and also with Github Codespaces.
The line to prevent Go Tools installation depends on a PR at the Go Devcontainer-Feature:
devcontainers/features#1729
But it does not harm current or prior versions, although the Go-Installation takes a few moments longer then.