Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Date chip parsing. #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add the Date chip parsing. #105

wants to merge 1 commit into from

Conversation

jbeder
Copy link

@jbeder jbeder commented Mar 20, 2022

Also add a formatting option formatISODate (in the UI "Format dates as YYYY-MM-DD"); when enabled, formats date chips as YYYY-MM-DD, and when disabled, formats date chips as they're displayed in the document (see https://developers.google.com/apps-script/reference/document/date#getDisplayText()).

Also add a formatting option formatISODate (in the UI "Format dates as YYYY-MM-DD"); when enabled, formats date chips as YYYY-MM-DD, and when disabled, formats date chips as they're displayed in the document (see https://developers.google.com/apps-script/reference/document/date#getDisplayText()).
@jbeder
Copy link
Author

jbeder commented Mar 20, 2022

I shared my copy of the verification document (here, but only you have access, not random passers-by).

This is partial support for #99, which asks for all smart chips (not just dates).

Also, I'm open to suggestions about formatting options. I need ISO format (YYYY-MM-DD) for myself, and I figure a good default is whatever is displayed in the doc.

@evbacher
Copy link
Owner

Hi Jesse -- thanks for this contribution! I will try to take a look later this week when I have some time for this project.

Copy link

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants