Splrep repro with mdspan #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FITPACK clones without FITPACK
Copy scipy/special/special/mdspan.h to scipy/_build_utils/src This mdspan implementation is written by Irwin Zaid, and is taken from the SciPy main branch as of scipy@f305bdf co-authored-by: Irwin Zaid <[email protected]>
It does not have layout_right, so use layout_stride instead.
ev-br
force-pushed
the
splrep_repro
branch
2 times, most recently
from
64d7ef0 to
2aa353a
Compare
ev-br
force-pushed
the
splrep_repro
branch
2 times, most recently
from
f25a4da to
02a3826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy @izaid's mdspan implementation from scipy/special/special, drop it into build_utils.
A small addition for the boundschecking layout-policy is a clumsy clone of the std::layout_strided. Irwin suggested to have a templated version instead. That'd be a nice cleanup, is not essential for tge first version.
Reference issue
What does this implement/fix?
Additional information