Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/19020 --- expm zero scratch arrays #12

Closed
wants to merge 3 commits into from
Closed

Pr/19020 --- expm zero scratch arrays #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ebc311
FIX:linalg:Use zero arrays for expm scratch arrays
ilayn Aug 5, 2023
8fb5e3b
BUG: linalg/expm: initialize the work array
ev-br Mar 10, 2024
d27587c
CI: WIP: allow CI to run on my fork
ev-br Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/linux_meson.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
# the usual skipping should not be enforced
if: >
needs.get_commit_message.outputs.message == 1
&& (github.repository == 'scipy/scipy' || github.repository == '')
&& (github.repository == 'ev-br/scipy' || github.repository == '')
runs-on: ubuntu-22.04
strategy:
matrix:
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
needs: get_commit_message
if: >
needs.get_commit_message.outputs.message == 1
&& (github.repository == 'scipy/scipy' || github.repository == '')
&& (github.repository == 'ev-br/scipy' || github.repository == '')
runs-on: ubuntu-22.04
steps:
- uses: actions/[email protected]
Expand Down Expand Up @@ -193,7 +193,7 @@ jobs:
needs: get_commit_message
if: >
needs.get_commit_message.outputs.message == 1
&& (github.repository == 'scipy/scipy' || github.repository == '')
&& (github.repository == 'ev-br/scipy' || github.repository == '')
runs-on: ubuntu-22.04 # provides python3.10-dbg
steps:
- uses: actions/[email protected]
Expand Down Expand Up @@ -223,7 +223,7 @@ jobs:
needs: get_commit_message
if: >
needs.get_commit_message.outputs.message == 1
&& (github.repository == 'scipy/scipy' || github.repository == '')
&& (github.repository == 'ev-br/scipy' || github.repository == '')
runs-on: ubuntu-20.04 # 22.04 doesn't support gcc-8
steps:
- uses: actions/[email protected]
Expand Down Expand Up @@ -275,7 +275,7 @@ jobs:
needs: get_commit_message
if: >
needs.get_commit_message.outputs.message == 1
&& (github.repository == 'scipy/scipy' || github.repository == '')
&& (github.repository == 'ev-br/scipy' || github.repository == '')
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down Expand Up @@ -361,7 +361,7 @@ jobs:
needs: get_commit_message
if: >
needs.get_commit_message.outputs.message == 1
&& (github.repository == 'scipy/scipy' || github.repository == '')
&& (github.repository == 'ev-br/scipy' || github.repository == '')
runs-on: ubuntu-latest
# I tried running directly in a container:, using the image: and options:
# entries. Unfortunately at this time options: does not seem to listen to
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linux_musl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
# the usual skipping should not be enforced
if: >
needs.get_commit_message.outputs.message == 1
&& (github.repository == 'scipy/scipy' || github.repository == '')
&& (github.repository == 'ev-br/scipy' || github.repository == '')
container:
# Use container used for building musllinux wheels
# it has git installed, all the pythons, etc
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/macos_meson.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
# the usual skipping should not be enforced
if: >
needs.get_commit_message.outputs.message == 1
&& (github.repository == 'scipy/scipy' || github.repository == '')
&& (github.repository == 'ev-br/scipy' || github.repository == '')
runs-on: macos-latest
strategy:
matrix:
Expand Down Expand Up @@ -143,7 +143,7 @@ jobs:
# the usual skipping should not be enforced
if: >
needs.get_commit_message.outputs.message == 1
&& (github.repository == 'scipy/scipy' || github.repository == '')
&& (github.repository == 'ev-br/scipy' || github.repository == '')
runs-on: macos-14
strategy:
matrix:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
# (b) it does run with Act locally (`github` doesn't exist there)
if: >
needs.get_commit_message.outputs.message == 1
&& (github.repository == 'scipy/scipy' || github.repository == '')
&& (github.repository == 'ev-br/scipy' || github.repository == '')
runs-on: windows-2019
steps:
- name: Checkout
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
needs: get_commit_message
if: >
needs.get_commit_message.outputs.message == 1
&& (github.repository == 'scipy/scipy' || github.repository == '')
&& (github.repository == 'ev-br/scipy' || github.repository == '')
runs-on: windows-2019
steps:
- name: Checkout
Expand Down Expand Up @@ -107,7 +107,7 @@ jobs:
needs: get_commit_message
if: >
needs.get_commit_message.outputs.message == 1
&& (github.repository == 'scipy/scipy' || github.repository == '')
&& (github.repository == 'ev-br/scipy' || github.repository == '')
runs-on: windows-2019
steps:
- name: Checkout
Expand Down
3 changes: 2 additions & 1 deletion scipy/linalg/_matfuncs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,8 @@ def expm(A):
n = a.shape[-1]
eA = np.empty(a.shape, dtype=a.dtype)
# working memory to hold intermediate arrays
Am = np.empty((5, n, n), dtype=a.dtype)
# For some reason np.empty causes issues; see gh-18086
Am = np.zeros((5, n, n), dtype=a.dtype)

# Main loop to go through the slices of an ndarray and passing to expm
for ind in product(*[range(x) for x in a.shape[:-2]]):
Expand Down
Loading
Loading