[Needs discussion] Fix assoc :key behavior#450
Open
Affonso-Gui wants to merge 1 commit intoeuslisp:masterfrom
Open
[Needs discussion] Fix assoc :key behavior#450Affonso-Gui wants to merge 1 commit intoeuslisp:masterfrom
Affonso-Gui wants to merge 1 commit intoeuslisp:masterfrom
Conversation
Affonso-Gui
added a commit
to Affonso-Gui/EusLisp
that referenced
this pull request
Feb 16, 2023
Affonso-Gui
added a commit
to Affonso-Gui/EusLisp
that referenced
this pull request
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EusLisp have the non-standard behavior of applying assoc's :key argument on each form, instead of on each of its car values:
This PR implements the standard :key argument behavior in EusLisp as well.
This is not backward compatible, but I am opening it because Inaba-sensei has pointed the EusLisp behavior as a bug (#436), granted that 'nobody is using this in code' and asked for a PR.
@inabajsk