Allow resetting to previous error stacks; Fixes to toplevel variable evaluation#362
Closed
Affonso-Gui wants to merge 2 commits intoeuslisp:cl-compatiblefrom
Closed
Allow resetting to previous error stacks; Fixes to toplevel variable evaluation#362Affonso-Gui wants to merge 2 commits intoeuslisp:cl-compatiblefrom
Affonso-Gui wants to merge 2 commits intoeuslisp:cl-compatiblefrom
Conversation
Member
Author
|
@k-okada Please review |
Member
Author
|
Added commit to solve the following problems in toplevel variable evaluation:
With this changes: 1.eus$ 10
10
2.eus$ *
10
3.eus$ * 2 2
4
4.eus$ ls
c Makefile.Cygwin Makefile.IRIX5 Makefile.LinuxSH4.2 Makefile.SunOS5.X11R6.1
comp Makefile.Cygwin32 Makefile.IRIX6 Makefile.Linux.thread opengl
geo Makefile.Cygwin64 Makefile.Linux Makefile.rgc README
image Makefile.Darwin Makefile.Linux64 Makefile.SunOS4 README.rgc
l Makefile.generic1 Makefile.LinuxARM Makefile.SunOS4.sub tool
Makefile Makefile.generic2 Makefile.Linux.ppc Makefile.SunOS5 xwindow
Makefile.Alpha Makefile.IRIX Makefile.LinuxSH4 Makefile.SunOS5.i386
0
5.eus$ guiga
sh: 1: guiga: not found
Call Stack (max depth: 20):
0: at #<compiled-code #X52d7e80>
eus 0 error: unbound variable guiga in #<compiled-code #X52d7e80>
6.E1-eus$ Note that
|
Member
Author
|
@k-okada @furushchev @mmurooka Accepting comments. |
Member
Author
|
Changed base to |
This was referenced Mar 27, 2019
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
resettakes an optional argument to select which level it should reset (throw). However, in current implementation the stack always wind back to level 0, independently of the argument given.Example below.
With this fixes,
(reset 2)throws 2 and goes back to level 1:@inabajsk