-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #106: Implementing skip-empty-xacts
.
#120
base: master
Are you sure you want to change the base?
Conversation
What is the reasoning behind not defaulting this to |
@joekohlsdorf backward compatibility. I think the plugin should behave the same for current users. Current users already get empty transactions and I think they are dealing with them already. |
In this particular case I would argue that the users aren't doing anything with empty transactions. So there is nothing lost by removing them because they contain no information at all. |
Any chance of merging this PR? |
@eulerto sure. I can update it on the weekend. What do you mean by "both formats"? |
@bahaa: there's an option |
@jmealo Thank you. I forked my version before there was support for two formats. I'll try to fix it this weekend. |
Looking forward to getting this feature. @bahaa any update on this? |
@bahaa would be great to get this merged |
@bahaa pls merge this. |
@bahaa if you are unable to work on this, I will be more than happy to take it further. |
@adrijshikhar sure. I'd be so glad if you do. |
sure i will pick this up |
Adding new parameter
skip-empty-xacts
. I chose the same parameter name as Postgres'test_decoding
.This should resolve #106.