BAEL-7881: Introduction to SootUp #18106
Open
+363
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theangrydev
requested changes
Dec 22, 2024
|
|
||
| public class AnalyzeUnitTest { | ||
| @Test | ||
| void whenAnalyzingTheJVM_thenWeCanListClasses() { |
There was a problem hiding this comment.
We follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case
Suggested change
| void whenAnalyzingTheJVM_thenWeCanListClasses() { | |
| void whenAnalyzingTheJvm_thenWeCanListClasses() { |
|
|
||
| JavaView view = new JavaView(inputLocation); | ||
|
|
||
| assertTrue(view.getClasses().size() > 0); |
There was a problem hiding this comment.
For complex assertions we use AssertJ
| StmtGraph<?> stmtGraph = methodBody.getStmtGraph(); | ||
| List<Stmt> stmts = stmtGraph.getStmts(); | ||
| for (Stmt stmt : stmts) { | ||
| System.out.println(stmt); |
There was a problem hiding this comment.
Can we assert here instead of printing?
|
|
||
| private void someMethod(String name) { | ||
| var capitald = name.toUpperCase(); | ||
| System.out.println("Hello, " + capitald); |
There was a problem hiding this comment.
We have a guideline to use SLF4J not System.out for print statements
There was a problem hiding this comment.
This method isn't being used. It's purely here so that it can be analyzed. I just needed to do something with the capitals variable was all.
Comment on lines
+59
to
+74
| @Test | ||
| void whenAnalyzingThisClass_thenWeCanListMethodsByName() { | ||
| Path javaFile = Path.of("src/test/java/com/baeldung/sootup/MethodUnitTest.java"); | ||
| AnalysisInputLocation inputLocation = new OTFCompileAnalysisInputLocation(javaFile); | ||
|
|
||
| JavaView view = new JavaView(inputLocation); | ||
|
|
||
| IdentifierFactory identifierFactory = view.getIdentifierFactory(); | ||
| ClassType javaClass = identifierFactory.getClassType("com.baeldung.sootup.MethodUnitTest"); | ||
|
|
||
| SootClass sootClass = view.getClassOrThrow(javaClass); | ||
| Set<? extends SootMethod> method = sootClass.getMethodsByName("someMethod"); | ||
| assertEquals(1, method.size()); | ||
| } | ||
|
|
||
| private void someMethod(String name) {} |
There was a problem hiding this comment.
Can we show multiple overloaded methods with the same name listed here perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.