-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ffprobe-static and adapt ffmpeg-static repository to support both packages #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modified build/index.sh
works. 👍
I have some further remarks on how to structure the code.
dfc9332
to
802d1b7
Compare
802d1b7
to
3a244bc
Compare
I've updated things from your comments @derhuerst but there are still things missing, I'll do this incrementally since I'm a little bit unsure how you wanna structure it. I've only created the subfolder for I created a Regarding the |
Any news on this guys ? 😁 |
I'm still waiting for feedback from @derhuerst (or other maintainers) since I don't wanna move forward without some form of approval |
There are several unrelated stylistic changes in here unfortunately; I will try to remove them, squash some commits, and then merge everything. Edit: In the |
fixes #19 closes #113 Co-Authored-By: Jannis R <[email protected]>
Sorry I kind of lost track of this issue for a little while. I just wanna reach out and check if there is anything that you would like some help with @derhuerst? |
fixes #19 closes #113 Co-Authored-By: Jannis R <[email protected]>
As an update for everyone: The missing binaries aside, the code in the Now it is up to the binary publishers to publish |
FYI: I have added |
Todo:
fixes #19