Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ffprobe-static and adapt ffmpeg-static repository to support both packages #113

Closed

Conversation

emilsivervik
Copy link
Contributor

@emilsivervik emilsivervik commented Aug 26, 2022

Todo:

  • Missing source for ffprobe binary on Darwin ARM64

fixes #19

@emilsivervik emilsivervik changed the title feat: rewrite install.js to read binary info from package file add ffprobe-static and adapt ffmpeg-static repository to support both packages Sep 7, 2022
Copy link
Collaborator

@derhuerst derhuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modified build/index.sh works. 👍

I have some further remarks on how to structure the code.

.github/workflows/release-binaries.yml Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
install.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@emilsivervik emilsivervik force-pushed the feat/add_ffprobe_static branch 3 times, most recently from dfc9332 to 802d1b7 Compare September 16, 2022 17:26
@emilsivervik
Copy link
Contributor Author

I've updated things from your comments @derhuerst but there are still things missing, I'll do this incrementally since I'm a little bit unsure how you wanna structure it. I've only created the subfolder for ffmpeg-static since I think it will be easier just getting the structure right and then it's more or less copy paste from there.

I created a copy.js file which does the template migration and I created a _package.json file which consists of all the relevant information for each specific package but you're more then welcome to leave suggestions for renaming and w/e to the flow since I'm not sure I like it how it is now.

Regarding the ffprobe-static package, is that something we should copy from the existing https://github.com/joshwnj/ffprobe-static repo or should as just try and keep both ffmpeg and ffprobe subfolder super-simliar?

@michael-dm
Copy link

Any news on this guys ? 😁

@emilsivervik
Copy link
Contributor Author

Any news on this guys ? 😁

I'm still waiting for feedback from @derhuerst (or other maintainers) since I don't wanna move forward without some form of approval

package.json Show resolved Hide resolved
@derhuerst derhuerst self-assigned this Dec 2, 2022
@derhuerst
Copy link
Collaborator

derhuerst commented Dec 2, 2022

There are several unrelated stylistic changes in here unfortunately; I will try to remove them, squash some commits, and then merge everything.

Edit: In the ffprobe branch.

derhuerst added a commit that referenced this pull request Dec 2, 2022
@emilsivervik
Copy link
Contributor Author

Sorry I kind of lost track of this issue for a little while. I just wanna reach out and check if there is anything that you would like some help with @derhuerst?

derhuerst added a commit that referenced this pull request Feb 22, 2023
@derhuerst
Copy link
Collaborator

As an update for everyone: The missing binaries aside, the code in the ffprobe branch is working as intended.

Now it is up to the binary publishers to publish ffprobe binaries (next to up-to-date ffmpeg binaries, see #110). Then, I can merge and publish this. 🚀

@derhuerst
Copy link
Collaborator

Missing source for ffprobe binary on Darwin ARM64

FYI: I have added ffprobe binaries to the list in #110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide ffprobe binaries again?
3 participants