Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide ffprobe binaries again? #19

Open
sballesteros opened this issue May 20, 2018 · 22 comments
Open

provide ffprobe binaries again? #19

sballesteros opened this issue May 20, 2018 · 22 comments

Comments

@sballesteros
Copy link

sballesteros commented May 20, 2018

Would it be possible to keep the ffprobe executable and also export the path to ffprobe ?

@derhuerst
Copy link
Collaborator

I don't think putting it in the ffmpeg-static npm packages is a good idea, as they are nicely focused and already ~100mb in size.

Publishing a second ffprobe-static from this GitHub repo would work. Let's ask @joshwnj it they are willing to donate the ffprobe-static npm name for this.

@sballesteros
Copy link
Author

Ha yes great idea!

@joshwnj
Copy link

joshwnj commented May 28, 2018

@derhuerst absolutely! Makes a lot of sense.

I can also add a deprecation notice to https://github.com/joshwnj/ffprobe-static pointing people back here.

I've never changed ownership of an npm package before, is there a preferred way to approach it? If I invite you to be a maintainer will that be enough?

@derhuerst
Copy link
Collaborator

@derhuerst absolutely! Makes a lot of sense.

Cool!

I can also add a deprecation notice to https://github.com/joshwnj/ffprobe-static pointing people back here.

The idea is to use your npm package just like it is being used right now: to ship ffprobe binaries via npm. The difference is only that we will use one repo (i guess this one) and publish both ffmpeg-static and ffprobe-static.

I've never changed ownership of an npm package before, is there a preferred way to approach it? If I invite you to be a maintainer will that be enough?

Giving someone push access to npm for the package would be sufficient. This will be necessary once @sballesteros or someone has prepared this repo to publish both.

@joshwnj
Copy link

joshwnj commented May 28, 2018

Great. In that case I'll keep an eye out here for when the new publishing approach is ready, and assign push access on npm then. Thanks!

@sballesteros
Copy link
Author

@derhuerst great, i can probably send a PR within the next 10 days.

@mifi
Copy link

mifi commented May 3, 2020

Any updates on this? 😄

@minism
Copy link

minism commented Nov 30, 2020

Ping. Any update?

@derhuerst derhuerst changed the title keep ffprobe ? provide ffprobe binaries again? Nov 30, 2020
@derhuerst
Copy link
Collaborator

derhuerst commented Nov 30, 2020

By now the binaries are being downloaded on install from a GitHub Release; That changes the situation quite a bit, because the npm package won‘t be ridiculously large anymore. So let‘s add ffprobe.

Still, I‘d like to avoid downloading ffprobe unnecessarily, so adopting the ffprobe-static to be published from this repo as well would be my favorite setup. I think this can be done with a little bit of scripting:

  • Change install.js to pick the name of the binary to be downloaded from package.json.
  • Add two directories for the two npm packaes, with minimal boilerplate inside.
  • On publish, copy install.js and all other shared files (license, etc) into the packages‘ directories and publish them to npm.

A PR that makes these changes is very welcome!

@jpvg10
Copy link

jpvg10 commented Dec 15, 2020

Hello guys! Now that you're at it, any chance of doing the same for ffplay? I looked around and didn't find a solution as neat as this one...

I know it involves work, just wanted to drop the comment just in case 😅

@mifi
Copy link

mifi commented Dec 15, 2020

I think once ffprobe support is added, then adding support for ffplay would be super simple, given that prebuilt ffplay binaries exist too in the source repos

@overlookmotel
Copy link

Is there a MacOS ARM64 static build of ffprobe available anywhere?

@jkb-kt
Copy link

jkb-kt commented Sep 12, 2021

ffprobe binary for M1 would surely be much appreciated!

@emilsivervik
Copy link
Contributor

Hello,

I’m from a company called Storykit and we’re using both ffmpeg-static and ffprobe-static quite extensively for our different services so we’d thought this would be a nice way to contribute to the eco system by looking at this issue.

We’ll start of by forking this repository and get to work so we can publish the required binaries and whatnot in our own phase independent of your schedule and then we can just have a conversation along the way with our progress and the things we’ll require from you guys to finally get the changes to this repository.

@longnguyen2004
Copy link

What's the progress on this? I'm also in need of ffprobe

@emilsivervik
Copy link
Contributor

I'm currently looking into where it's possible to download the the Darwin ARM64 for ffprobe, I've contacted the people at http://www.osxexperts.net/ (since we're downloading the ffmpeg binary from there) at [email protected] to see if they could provide it but they have not yet replied to me. Is there any suggestion/guidelines if we should move along without this or if anybody has an alternative source to download it from?

Current progress can be tracked in my PR: #113

@derhuerst
Copy link
Collaborator

@joshwnj This repo is now ready for publishing [email protected], analogous to [email protected]. Can you give me (@derhuerst) write access to the npm package?

@jonluca
Copy link

jonluca commented Jul 31, 2023

bump @joshwnj would be great to have this all in one package

@eli4n
Copy link

eli4n commented Aug 22, 2023

bump @joshwnj :)

@kelihansen
Copy link

🙏 @joshwnj

@ajfranzoia
Copy link

@derhuerst is this still an issue? I'm trying to install ffprobe using https://www.npmjs.com/package/ffprobe-static, but it downloads version 3.2.0 (which contains binaries for all oss) and not the one published by you. Please lmk if I'm doing something wrong

@TiddoLangerak
Copy link

If @joshwnj can't give write access, then maybe @derhuerst can publish it under a different name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet