Fix Mypy error #79
Merged
Fix Mypy error #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for opening this PR @Divelix! The changes look good to me.
The CI pipeline for ROS1 is failing, but it can't be due to your changes. I'm currently out of office, but I'll debug the issue, prepare the release, and merge this PR by next week.
victorreijgwart
force-pushed
the
fix-mypy
branch
from
119853f
to
a23ae86
Compare
|
@Divelix, the issue in the ROS1 CI pipeline seems to be that PRs from forks are not allowed to update wavemap's packages. I'm still looking into a good long-term solution, but in the meantime, I'll "import" your code changes into a feature branch on our repo (allowing the ROS tests to run) and then merge to main from there. |
victorreijgwart
changed the base branch from
main
to
feature/add_py_typed_marker_file
victorreijgwart
merged commit 7790319
into
ethz-asl:feature/add_py_typed_marker_file
24 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change fixes Mypy error:
in VSCode for
import pywavemapline.