[ROS2] Backport removal of viewpoint object #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jaeyoung-Lim there are some conflicts here because the code in the header has been moved to a cpp in the |
|
@srmainwaring That would be great, thanks! |
|
@Jaeyoung-Lim - if you are ok with the changes in #48 I can squash them with the commits in this PR and force push (or do the rebase merge of #48 then squash after). |
Co-authored-by: JaeyoungLim <[email protected]> Co-authored-by: Rhys Mainwaring <[email protected]> Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring
force-pushed
the
pr-backport-viewpoint
branch
from
bb82f05
to
cbca0b0
Compare
|
@srmainwaring Wow amazing! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Backport of #29