Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the compiler warnings. A few of the functions had unused
epsilon
values.In
getClosestPoint
, I used the epsilon value from the function in a place that seems correct, however they were different by an order of magnitude. If you think that's wrong, let me know.Finally, the pi-wrapping functions were converted to inline because they were defined and used in different translation units:
Using inline stops the compiler from caring about that. I looked briefly to see if there was any pi-wrapping utilities in eigen, but could not find any. There are numerous optimizations that can be made to the current algorithm, but I'm not going to bother until we have benchmarking set up.