-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hack/force sensor #686
Open
maxb91
wants to merge
17
commits into
master
Choose a base branch
from
hack/force_sensor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hack/force sensor #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds with OpenCV4
…mit into a new dedicated branch for the mini voliro. This reverts commit 547415a.
Can one of the admins verify this patch? |
servo motor number was incremented by hardcoded value 12. This only works if you have 12 normal motors.... Macro now requires the number of the tilt-motor to be specified. Only changed for single-rotor unit (for now) to keep backwards compatibility with the old OMAV
…tor into hack/force_sensor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes w.r.t. master:
In my opinion the naming 'hack' is a bit misleading as it only refers to rotating the force/torque measurements into our commonly used frame before publishing them. (line shown below)
As the changes should not interfere with any other existing simulations I'd suggest we should merge it to master.
rotors_simulator/rotors_gazebo_plugins/src/gazebo_force_sensor_plugin.cpp
Line 216 in 67694ce