Deterministic Contract Deployment & Easy Verification

[seongyun-ko]

The script deployment/deploy.s.sol deployment/deploy.s.sol) provides a standardized, easy-to-review deployment flow using a deterministic contract deployment flow with Create2. It logs all deployment parameters and addresses in a structured JSON file for easy review and reproducibility. EtherFiRedemptionManager is used as an example.

Security Guarantee

By using CREATE2 with a fixed salt and bytecode, the deployed contract address is fully predictable and verifiable before upgrade, ensuring no surprises or hidden logic.

Reviewability

All constructor arguments and deployment metadata are automatically saved and human-readable, making audits and reviews straightforward and transparent for any contract deployed with this script.

Example output json file after deployment for archiving

{
  "contractName": "EtherFiRedemptionManager",
  "deploymentParameters": {
    "factory": "0x356d1B83970CeF2018F2c9337cDdb67dff5AEF99",
    "salt": "0x46a81769b944c166e46b4e02c4e78fade102d288000000000000000000000000",
    "constructorArgs": {
      "_liquidityPool": "0x0000000000000000000000000000000000000000",
      "_eEth": "0x0000000000000000000000000000000000000000",
      "_weEth": "0x0000000000000000000000000000000000000000",
      "_treasury": "0x0000000000000000000000000000000000000000",
      "_roleRegistry": "0x0000000000000000000000000000000000000000"
    }
  },
  "deployedAddress": "0x6BD8EA55e4522e4bDF71ECBa31b4d633A88aBB8c"
}

[shivam-ef]

LGTM LFG!!!!

[solipsis]

Looks good. One thing to maybe consider. Would we want the salt to be ether.fi-{commitSlug}? i.e. ether.fi-abc123

Could be nice to know exactly which commit each deployment should come from

[seongyun-ko]

Looks good. One thing to maybe consider. Would we want the salt to be ether.fi-{commitSlug}? i.e. ether.fi-abc123

Could be nice to know exactly which commit each deployment should come from

Good idea. I updated the script to use the commit hash to generate the salt with right padding