Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update submodule and missing workspace member #1633

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

njgheorghita
Copy link
Collaborator

@njgheorghita njgheorghita commented Jan 13, 2025

What was wrong?

I'm chasing down a bug in hive, and noticed that trin doesn't have the latest version of portal-spec-tests

On another note, I think we lost a lot of test coverage (at the very least ethportal-peertest doesn't seem to be running) with the recent refactor in #1624 ... but I'm still chasing that down and will address it in a future pr.

How was it fixed?

  • Updated submodule
  • Added missing workspace member

To-Do

@KolbyML
Copy link
Member

KolbyML commented Jan 13, 2025

On another note, I think we lost a lot of test coverage (at the very least ethportal-peertest doesn't seem to be running) with the recent refactor in #1624 ... but I'm still chasing that down and will address it in a future pr.

#1632 I have ethportal-peertest running in my new refactor PR no?

Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@njgheorghita
Copy link
Collaborator Author

@KolbyML Ok yeah that looks like it's working. Not sure why it wasn't during this "intermediary" stage between the prs ( are we sure that we haven't lost any other test coverage during this refactor? )

@KolbyML
Copy link
Member

KolbyML commented Jan 13, 2025

@KolbyML Ok yeah that looks like it's working. Not sure why it wasn't during this "intermediary" stage between the prs ( are we sure that we haven't lost any other test coverage during this refactor? )

I figured out the issue refactor: create separate binary crates and move TrinConfig to trin crate

Apparently tests folders must be in a crate and since we moved the trin crate from the root directory to /bin/trin the tests folder ethportal-peertests was being ran from was no longer in a crate, hence it no longer ran.

So my refactor: move crate ethportal-peertest to testing/ethportal-peertest PR fixes the problem via moving the tests folder back into a crate within the workspace

@njgheorghita njgheorghita merged commit 3be17e5 into ethereum:master Jan 14, 2025
11 checks passed
@njgheorghita njgheorghita deleted the update-submodule branch January 14, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants