Compilers package #1914
Compilers package #1914
Conversation
manuelwedler
force-pushed
the
compiler-package
branch
from
7564f70 to
fb670aa
Compare
in order to avoid a circular dependency graph
manuelwedler
force-pushed
the
compiler-package
branch
from
fb670aa to
56388ae
Compare
manuelwedler
force-pushed
the
compiler-package
branch
from
56388ae to
80076c5
Compare
| @@ -37,8 +35,8 @@ export function findVyperPlatform(): string | false { | |||
| export async function useVyperCompiler( | |||
| vyperRepoPath: string, | |||
| version: string, | |||
| vyperJsonInput: VyperJsonInput, | |||
| ): Promise<VyperOutput> { | |||
| vyperJsonInput: any, | |||
There was a problem hiding this comment.
In the new verification flow PR there are a lot of new types like this one. I'm wondering if we should move them in this new package. Also I see here you removed the type, why?
There was a problem hiding this comment.
I removed it because we would have a circular dependency graph if lib-sourcify would be a dependency for compilers. Lerna was complaining about this first.
I also thought about moving the types to the compilers package. I think it can makes sense, but it would also couple lib-sourcify more tightly with compilers and make the compilers package a requirement for anyone who is using lib-sourcify.
There was a problem hiding this comment.
Mhhh I already don't like this :D The only solution I see other than including the types in the compiler package is to create another compiler-types package
| @@ -0,0 +1,83 @@ | |||
| { | |||
There was a problem hiding this comment.
We should also setup running the tests in the debugger with .vscode configuration
There was a problem hiding this comment.
ah right. I forgot that
Closes #1348
This simply moves the useCompiler functions to a new public package without refactoring the code much.