Fix analysis storage size check incorrectly including transient storage variables #15901

matheusaaguiar · 2025-02-28T03:19:32Z

Fix #15899.

test/libsolidity/syntaxTests/largeTypes/max_size_array_with_transient_state_variables.sol

libsolidity/analysis/ContractLevelChecker.cpp

Changelog.md

libsolidity/ast/ASTUtils.cpp

libsolidity/analysis/ContractLevelChecker.h

cameel

The code is correct so I'm approving already, but there are a few small things we could still improve here.

libsolidity/analysis/ContractLevelChecker.cpp

libsolidity/ast/ASTUtils.cpp

test/libsolidity/syntaxTests/largeTypes/oversized_array_lenght.sol

libsolidity/ast/ASTUtils.h

matheusaaguiar self-assigned this Feb 28, 2025

matheusaaguiar changed the title ~~Fix storage size bug~~ Fix analysis storage size check incorrectly including transient storage variables Feb 28, 2025

cameel reviewed Feb 28, 2025

View reviewed changes

test/libsolidity/syntaxTests/largeTypes/max_size_array_with_transient_state_variables.sol Outdated Show resolved Hide resolved

libsolidity/analysis/ContractLevelChecker.cpp Outdated Show resolved Hide resolved

Changelog.md Outdated Show resolved Hide resolved

matheusaaguiar force-pushed the fixStorageSizeBug branch from db4632c to 107fc9a Compare February 28, 2025 05:16

matheusaaguiar commented Feb 28, 2025

View reviewed changes

libsolidity/ast/ASTUtils.cpp Outdated Show resolved Hide resolved

matheusaaguiar commented Feb 28, 2025

View reviewed changes

libsolidity/analysis/ContractLevelChecker.h Outdated Show resolved Hide resolved

matheusaaguiar force-pushed the fixStorageSizeBug branch from 5be2c62 to ea09648 Compare February 28, 2025 05:48

cameel previously approved these changes Feb 28, 2025

View reviewed changes

libsolidity/analysis/ContractLevelChecker.cpp Outdated Show resolved Hide resolved

libsolidity/ast/ASTUtils.cpp Outdated Show resolved Hide resolved

test/libsolidity/syntaxTests/largeTypes/oversized_array_lenght.sol Outdated Show resolved Hide resolved

matheusaaguiar dismissed cameel’s stale review via c60da6d February 28, 2025 22:22

matheusaaguiar force-pushed the fixStorageSizeBug branch from ea09648 to c60da6d Compare February 28, 2025 22:22

cameel previously approved these changes Feb 28, 2025

View reviewed changes

libsolidity/ast/ASTUtils.h Outdated Show resolved Hide resolved

matheusaaguiar dismissed cameel’s stale review via fd89bec February 28, 2025 23:37

matheusaaguiar force-pushed the fixStorageSizeBug branch from fd89bec to f50e2ff Compare February 28, 2025 23:38

cameel approved these changes Feb 28, 2025

View reviewed changes

matheusaaguiar added 3 commits March 2, 2025 20:59

Fix wrong storage size computation

5fd8593

Add helper to calculate storage/transient size

aae841e

Add tests

e601d83

cameel force-pushed the fixStorageSizeBug branch from f50e2ff to e601d83 Compare March 2, 2025 19:59

cameel enabled auto-merge March 2, 2025 19:59

cameel merged commit a83a820 into develop Mar 2, 2025
74 checks passed

cameel deleted the fixStorageSizeBug branch March 2, 2025 20:39

cameel mentioned this pull request Mar 3, 2025

Adjust storage layout to consider explicit storage base location #15668

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix analysis storage size check incorrectly including transient storage variables #15901

Fix analysis storage size check incorrectly including transient storage variables #15901

matheusaaguiar commented Feb 28, 2025

cameel left a comment

Fix analysis storage size check incorrectly including transient storage variables #15901

Fix analysis storage size check incorrectly including transient storage variables #15901

Conversation

matheusaaguiar commented Feb 28, 2025

cameel left a comment

Choose a reason for hiding this comment