-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix errors in comments #15822
base: develop
Are you sure you want to change the base?
fix errors in comments #15822
Conversation
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
@cameel its true ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, so if you include your changes from #15876, we can merge this.
But please also fix your commits. They should have proper descriptions saying what you're changing - just saying which file was updated is useless (git already provides that information). In this case the changes are trivial enough that it would also be fine to just squash them into one commit.
std::std::string
, changing it to std::string
+ typo
@cameel done , thanks |
libsolc/libsolc.cpp
std::std::string --> std::std::string
fix duplicate std::
libsolidity/analysis/ControlFlowBuilder.h
is creates --> is created
libsolidity/interface/ABI.h
JSONrepresentation --> JSON representation