Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Boost_DIR with Boost_INCLUDE_DIR #15674

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gmh5225
Copy link

@gmh5225 gmh5225 commented Dec 24, 2024

No description provided.

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@r0qs
Copy link
Member

r0qs commented Dec 26, 2024

Hi @gmh5225, could you clarify what exactly is incorrect in the current configuration? Could you provide more details? Are you encountering any specific issues with the current settings?

@gmh5225
Copy link
Author

gmh5225 commented Dec 26, 2024

I found that using -DBoost_DIR actually fails to compile on Windows.
image

Using -DBoost_ROOT and -DBoost_INCLUDE_DIR is the more modern and recommended way since CMake 3.12+.
image

@r0qs

@cameel cameel changed the title fix correct Boost compilation flags Replace Boost_DIR with Boost_INCLUDE_DIR Dec 27, 2024
@cameel
Copy link
Member

cameel commented Dec 27, 2024

Just a heads up: please make sure this works also with Boost 1.67, which is the oldest version we still support. This is not covered by our CI (#15136).

@gmh5225
Copy link
Author

gmh5225 commented Dec 27, 2024

image
The minimum Boost version required on Windows is 1.77. I have tested it, and it works. The documentation fixes are specifically for compiling on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants