added nethermind evm to docker file #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsvega
reviewed
Jan 8, 2025
| @@ -21,16 +21,14 @@ void requireStateTestsFillerEnvScheme(spDataObject const& _data) | |||
| {"currentRandom", {{DataType::String}, jsonField::Optional}}, | |||
| {c_parentExcessBlobGas, {{DataType::String}, jsonField::Optional}}, | |||
| {c_parentBlobGasUsed, {{DataType::String}, jsonField::Optional}}, | |||
| {c_currentBeaconRoot, {{DataType::String}, jsonField::Optional}}, | |||
| {"previousHash", {{DataType::String}, jsonField::Required}}}); | |||
There was a problem hiding this comment.
this seems to be a rebase issue. can you rebase on top of develop branch?
winsvega
reviewed
Jan 8, 2025
| @@ -30,6 +32,10 @@ RUN apt-get update \ | |||
| && add-apt-repository -y ppa:deadsnakes/ppa \ | |||
| && add-apt-repository ppa:linuxuprising/java \ | |||
| && apt-get install --yes jq lsof git cmake make perl psmisc curl wget gcc-11 g++-11 python3.10 python3.10-venv python3-pip python3-dev \ | |||
| && wget https://packages.microsoft.com/config/ubuntu/$(lsb_release -rs)/packages-microsoft-prod.deb -O packages-microsoft-prod.deb \ | |||
There was a problem hiding this comment.
I think it is better to move this under condition as well. as if docker is being built for geth only no need to install nethermind pre requirements
winsvega
reviewed
Jan 8, 2025
| @@ -112,6 +112,9 @@ if [ "$SCRIPT_NAME" = "dtf.sh" ]; then | |||
| if [ "$var" = "nimbus" ]; then | |||
| binpath="/bin/evm_nimbus" | |||
| fi | |||
| if [ "$var" = "nethermind" ]; then | |||
| binpath="/nethermind/tools/Evm/Evm/bin/Debug/net8.0/Evm" | |||
There was a problem hiding this comment.
to save space I copy built binaries into bin folder inside docker and remove all src and build files that are no longer required for it to run. making docker image smaller.
|
@yerke26 |
winsvega
force-pushed
the
develop
branch
2 times, most recently
from
f7dfbd3 to
406bf87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build Nethermind Evm added to DockerFile
binary script is located here:
/usr/bin/nethermindevmyou can run it by:
/usr/bin/nethermindevm t8n