-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixmatomo #5242
Closed
Closed
Fixmatomo #5242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bunsenstraat
commented
Oct 2, 2024
•
edited
Loading
edited
- the modals where drawing focus to themselves if they were not visible causing the matomo to blur out
- added a preventBlur option to the modal to prevent blur if needed, this is only used on matomo now...
- there is now a timestamp set in localstorage which indicates when the user has reacted to the matomo dialog. if it's older than 6 months and the matomo setting is either false or not set it will ask for matomo permissions again. added this in e2e.
- added an event in matomo to show this happening
- loader.js would always consider permission granted when any value 'settings/matomo-analytics' was set, even when false.
- the modal cancel method now accepts an enum telling the callback what kind of cancel it was, close, escape, enter, click etc etc allowing. this allows the modal handler not to set the storage when it's a real blur.
- added e2e
- sometimes matomo was spelled matamo :D fixed that
LianaHus
reviewed
Oct 2, 2024
bunsenstraat
force-pushed
the
fixmatomo
branch
from
October 4, 2024 07:22
0d780a8
to
bf54716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.