Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixmatomo #5242

Closed
wants to merge 48 commits into from
Closed

Fixmatomo #5242

wants to merge 48 commits into from

Conversation

bunsenstraat
Copy link
Collaborator

@bunsenstraat bunsenstraat commented Oct 2, 2024

  • the modals where drawing focus to themselves if they were not visible causing the matomo to blur out
  • added a preventBlur option to the modal to prevent blur if needed, this is only used on matomo now...
  • there is now a timestamp set in localstorage which indicates when the user has reacted to the matomo dialog. if it's older than 6 months and the matomo setting is either false or not set it will ask for matomo permissions again. added this in e2e.
  • added an event in matomo to show this happening
  • loader.js would always consider permission granted when any value 'settings/matomo-analytics' was set, even when false.
  • the modal cancel method now accepts an enum telling the callback what kind of cancel it was, close, escape, enter, click etc etc allowing. this allows the modal handler not to set the storage when it's a real blur.
  • added e2e
  • sometimes matomo was spelled matamo :D fixed that

@bunsenstraat bunsenstraat requested a review from yann300 October 2, 2024 14:25
@bunsenstraat bunsenstraat marked this pull request as draft October 3, 2024 08:46
@bunsenstraat bunsenstraat marked this pull request as ready for review October 4, 2024 08:25
@bunsenstraat bunsenstraat marked this pull request as draft October 4, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants