Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP 712 #5237

Merged
merged 22 commits into from
Oct 16, 2024
Merged

EIP 712 #5237

merged 22 commits into from
Oct 16, 2024

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Sep 30, 2024 •
edited
Loading

  • from the old way of signing, add sign with EIP 712
  • add right click / Sign typed data (EIP712 compatible).

handle #4912 #4911

@netlify Netlify
Copy link

netlify bot commented Sep 30, 2024 •
edited
Loading

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 3c71f8f
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/670f728d4733780008315ef8
😎 Deploy Preview https://deploy-preview-5237--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yann300 yann300 force-pushed the fix_sign branch 3 times, most recently from 589a766 to 4a3bb71 Compare October 1, 2024 13:25
@yann300 yann300 requested review from LianaHus and ryestew October 1, 2024 13:32
@yann300 yann300 added the ready-to-review PR ready to review label Oct 1, 2024
@yann300 yann300 requested a review from Aniket-Engg October 1, 2024 13:32
@yann300 yann300 force-pushed the fix_sign branch 9 times, most recently from 7040039 to 7c635ee Compare October 7, 2024 12:48
@yann300
Copy link
Contributor Author

yann300 commented Oct 7, 2024 •
edited
Loading

  • should add matomo.
  • check the 32 bytes length message.
  • check with injected.
  • check dynamically the content before doing the signing (or make sure the web3 api returns a correct error).

@yann300 yann300 force-pushed the fix_sign branch 6 times, most recently from 7f78803 to b57f774 Compare October 15, 2024 12:24
@Aniket-Engg Aniket-Engg merged commit 7e44c51 into master Oct 16, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the fix_sign branch October 16, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aniket-Engg Aniket-Engg Aniket-Engg approved these changes

@LianaHus LianaHus Awaiting requested review from LianaHus

@ryestew ryestew Awaiting requested review from ryestew

Assignees
No one assigned
Labels
ready-to-review PR ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yann300 @Aniket-Engg