Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circom desktop #5228

Merged
merged 58 commits into from
Dec 13, 2024
Merged

Circom desktop #5228

merged 58 commits into from
Dec 13, 2024

Conversation

ioedeveloper
Copy link
Member

@ioedeveloper ioedeveloper commented Sep 26, 2024 •
edited
Loading

Closes #5142
Closes #5143

@netlify Netlify
Copy link

netlify bot commented Sep 26, 2024 •
edited
Loading

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit edbe91d
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/675ac778eb38590008acd80d
😎 Deploy Preview https://deploy-preview-5228--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ioedeveloper ioedeveloper added the ready-to-review PR ready to review label Sep 26, 2024
@yann300
Copy link
Contributor

yann300 commented Oct 2, 2024 •
edited
Loading

  • there should be a loading icon, when downloading the compiler and compiling the circuit.
  • when compiling from desktop, I get the error main.js:1 Error: Error fr ![remix](https://github.com/user-attachments/assets/7fabc892-b17e-4d52-b989-225ab10f8b12) om IDE : ENOTDIR: not a directory, mkdir '/opt/Remix-Desktop-Insiders/resources/app.asar/circom-download/latest'

remix

@ioedeveloper ioedeveloper force-pushed the circom-desktop branch 2 times, most recently from 60fa079 to fb93a9f Compare November 1, 2024 11:54
ioedeveloper and others added 27 commits December 12, 2024 12:22
@ioedeveloper @bunsenstraat
Limit permission to group
f82d8bf
@ioedeveloper @bunsenstraat
Get functioning path for macos
7c4a28b
@ioedeveloper @bunsenstraat
revert last changes
4327c07
@ioedeveloper @bunsenstraat
Log app paths for production build debugging
c741e15
@ioedeveloper @bunsenstraat
Use program dir for windows
d82c565
@ioedeveloper @bunsenstraat
Remove uneeded console log
7541261
@ioedeveloper @bunsenstraat
deleted file
76c0da1
@ioedeveloper @bunsenstraat
restore remix ai types file
a94afdb
@ioedeveloper @bunsenstraat
Only support circom_wasm versions for desktop too
10bcf77
@ioedeveloper @bunsenstraat
Only support circom_wasm versions for desktop too
4bd8f7b
@ioedeveloper @bunsenstraat
Fixed failing test
090c2c8
@ioedeveloper @bunsenstraat
Parse file before compiling for desktop
078a8f0
@ioedeveloper @bunsenstraat
Make path uniform for compiled circuit
4b273f7
@ioedeveloper @bunsenstraat
Ensure extension is replaced
407950b
@ioedeveloper @bunsenstraat
Update test with new path
b994182
@ioedeveloper @bunsenstraat
Update test with new path
0fb8171
@ioedeveloper @bunsenstraat
Replace wrong path
071ad07
@ioedeveloper @bunsenstraat
Normalize win32 path
8bca72c
@bunsenstraat
tests
ef2b78c
@bunsenstraat
try docker
dd174b8
@bunsenstraat
back to machine img
7b10583
@bunsenstraat
install npm
78de124
@bunsenstraat
add orb
b42a983
@bunsenstraat
yarn
d1fa4cc
@bunsenstraat
20.5
f2850d2
@bunsenstraat
node-gyp version
9ab48dc
@bunsenstraat
turn on script test
edbe91d
@bunsenstraat bunsenstraat merged commit 689acb2 into master Dec 13, 2024
41 checks passed
@bunsenstraat bunsenstraat deleted the circom-desktop branch December 13, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bunsenstraat bunsenstraat bunsenstraat approved these changes

@ryestew ryestew Awaiting requested review from ryestew

@yann300 yann300 Awaiting requested review from yann300

@Aniket-Engg Aniket-Engg Awaiting requested review from Aniket-Engg

Assignees
No one assigned
Labels
circom ready-to-review PR ready to review remix-desktop
Projects
None yet
Milestone
No milestone
3 participants
@ioedeveloper @yann300 @bunsenstraat