Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: implement EIP-7623 increase calldata cost #30946

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

core: implement EIP-7623 increase calldata cost #30946

wants to merge 1 commit into from

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Dec 20, 2024 •
edited
Loading

This PR builds on #29040 and updates it to the new version of the spec. I filled the EEST tests and they pass.

Link to spec: https://eips.ethereum.org/EIPS/eip-7623

@s1na s1na added the prague label Dec 20, 2024
@MariusVanDerWijden MariusVanDerWijden mentioned this pull request Dec 30, 2024
Closed
@MariusVanDerWijden MariusVanDerWijden changed the title Core: implement EIP-7623 increase calldata cost core: implement EIP-7623 increase calldata cost Jan 3, 2025
MariusVanDerWijden
MariusVanDerWijden previously approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I was a bit stumped by the changes to the test cases in internal/ethapi/testdata, but I figured out that these tests use the MergedTestChainConfig which already enables Prague, so the gas costs do not match anymore after this, which is expected.

2dvorak added a commit to 2dvorak/kaia that referenced this pull request Jan 7, 2025
@2dvorak
Bring geth updates for EIP-7623
ca46720 
Refer to ethereum/go-ethereum#30946.
That PR is ongoing so we may need further updates.
@2dvorak 2dvorak mentioned this pull request Jan 7, 2025
Merged
9 tasks
@lightclient lightclient force-pushed the eip-7623-rebased branch 2 times, most recently from f4575ba to 75b4157 Compare January 10, 2025 21:36
@MariusVanDerWijden @s1na @lightclient
core: implement eip-7623
49d2543 
Co-authored-by: Marius van der Wijden <[email protected]>
Co-authored-by: Sina Mahmoodi <[email protected]>
@lightclient
Copy link
Member

I rebased this into a single commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden left review comments

@fjl fjl Awaiting requested review from fjl fjl is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

@lightclient lightclient Awaiting requested review from lightclient lightclient is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
prague
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s1na @lightclient @MariusVanDerWijden