96 add correctness check #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perama-v
force-pushed
the
96-add-correctness-check
branch
from
5508ba9 to
6ea367a
Compare
|
Would someone mind also giving this a run and checking that validation is working as expected? I have also included pandaops connectivity with #102, but have not validated it works (I just copied from pandops setup elsewhere). Ideally this PR should be tested against that to make sure that it works before updating production glados. |
perama-v
force-pushed
the
96-add-correctness-check
branch
from
6ea367a to
9650ec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is me re-opening #100
@perama-v feel free to re-open your own version of this.